OragonEfreet/banjo
OragonEfreet/banjo
1
0
Fork 0
Code Issues 16 Pull requests Projects 1 Releases 4 Activity Actions

Fix macOS crash on quit due to CADisplayLink teardown race #128

Merged
OragonEfreet merged 1 commit from fix/macos-quit-crash into main 2026-06-01 13:55:00 +02:00
Conversation 0 Commits 1 Files changed 1 +17 -6
OragonEfreet commented 2026-06-01 09:47:39 +02:00
Owner
Copy link

Calling [CADisplayLink invalidate] directly during video teardown
could crash with "Unlock of an os_unfair_lock not owned by current
thread" if a display link callback was in progress.

Fix by:

  • Clearing the semaphore reference first to stop signaling
  • Dispatching invalidate asynchronously to main queue to ensure
    it runs after any in-progress callback completes
  • Guarding the callback against NULL semaphore
  • Removing manual dispatch_release (ARC manages dispatch objects)
Calling [CADisplayLink invalidate] directly during video teardown could crash with "Unlock of an os_unfair_lock not owned by current thread" if a display link callback was in progress. Fix by: - Clearing the semaphore reference first to stop signaling - Dispatching invalidate asynchronously to main queue to ensure it runs after any in-progress callback completes - Guarding the callback against NULL semaphore - Removing manual dispatch_release (ARC manages dispatch objects)
Fix macOS crash on quit due to CADisplayLink teardown race
All checks were successful
Documentation / build-docs (pull_request) Successful in 9s
Details
QA / cert (pull_request) Successful in 29s
Details
Build and Test / linux-linux-gcc (pull_request) Successful in 17s
Details
Build and Test / linux-windows-mingw (pull_request) Successful in 26s
Details
8923ef1ab7 
Calling [CADisplayLink invalidate] directly during video teardown
could crash with "Unlock of an os_unfair_lock not owned by current
thread" if a display link callback was in progress.

Fix by:
- Clearing the semaphore reference first to stop signaling
- Dispatching invalidate asynchronously to main queue to ensure
  it runs after any in-progress callback completes
- Guarding the callback against NULL semaphore
- Removing manual dispatch_release (ARC manages dispatch objects)
OragonEfreet added this to the 1.0 milestone 2026-06-01 09:47:50 +02:00
OragonEfreet deleted branch fix/macos-quit-crash 2026-06-01 13:55:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
OragonEfreet
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
OragonEfreet/banjo!128
No description provided.