Resize fixes #129

Merged

OragonEfreet merged 11 commits from wayland-libdecor into main 2026-06-01 13:54:51 +02:00

Conversation 0 Commits 11 Files changed 13 +660 -120

OragonEfreet commented 2026-06-01 12:27:04 +02:00

Owner

Copy link

No description provided.

OragonEfreet added 6 commits 2026-06-01 12:27:04 +02:00

Wayland: add libdecor shim and context plumbing 9efb87c283

Wayland: route windows through libdecor for decorations 7e6676f9b3

examples: make event_polling resizable, document libdecor plugin dep 8ac5ceae59

Wayland: keep libdecor decoration notes out of BUILDING.md 6ae6e06228

examples: make drawing_2d resizable via a fixed-resolution canvas ... 13b5ddef26

The scene uses hardcoded coordinates sized for 500x500, and the drawing
primitives don't clip, so drawing straight into a resizable framebuffer
would write out of bounds the moment the window shrinks. Instead render
the scene once into a fixed 500x500 off-screen canvas and scale that onto
the framebuffer each frame with bj_blit_stretched, which clips to the
destination. This is the fixed-internal-resolution pattern the
bj_window_resize_fn docs describe. The window gains
BJ_WINDOW_FLAG_RESIZABLE and the tutorial block explains the approach.

Also drop the manual bj_sleep from step: bj_run_app already paces the
loop to its frame rate, so the sleep only throttled event handling (and
made the resize crawl).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

examples: drop redundant bj_sleep in event_polling ... 740c159f87

bj_run_app paces the loop to its frame rate (60 Hz by default) and sleeps
off the remainder of each frame itself, so the manual bj_sleep(30) in step
was a leftover from before that pacing existed. It throttled the loop to
~33 Hz, which capped how fast the example acked Wayland resize configures
and made interactive resize lag. Remove it (and the now-unused time.h).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

OragonEfreet added 4 commits 2026-06-01 13:25:46 +02:00

examples: drop leftover bj_sleep from App render loops ... 26cff272c6

bj_run_app paces the loop to its frame rate (60 Hz by default) and sleeps
off the remainder of each frame itself, so a manual bj_sleep in step was
a leftover from before that pacing existed; it only throttled event
handling. Remove it from the event/render-loop examples along with the
now-unused time.h include, and drop the stray pacing comment a prior
step had left in drawing_2d.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

examples: drive sprite_animation off the frame delta ... c8ad543047

The 120 ms bj_sleep both set the animation speed and throttled the loop.
Advance one sprite frame per 120 ms accumulated from tick.delta instead,
so the animation runs at a fixed ~8 FPS independent of the loop rate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

examples: react to window resize in event_polling ... 9a71b1c4cb

Bring event_polling to feature parity with event_callbacks. The window
was already resizable but the example ignored resizes. Resize is not a
queued event type, so register a bj_set_resize_callback (as
event_callbacks does) and count/log it, showing input polling and a
resize callback coexisting.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

examples: make time and stopwatch plain console programs ... 872cc0280b

Neither has a window or events to drive, so wrapping them in bj_run_app
(setup/step/teardown) was ceremony that also made their bj_sleep look
like a redundant pacing leftover. Rewrite each as a plain main() loop
where bj_sleep legitimately paces its own loop. They are desktop-only as
a result (a blocking loop would not cooperate with the browser on an
Emscripten build), which is fine for a console timing demo.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

OragonEfreet changed title from WIP: Resize fixes to Resize fixes 2026-06-01 13:26:13 +02:00

OragonEfreet added this to the 1.0 milestone 2026-06-01 13:26:15 +02:00

OragonEfreet self-assigned this 2026-06-01 13:26:16 +02:00

OragonEfreet added the

bug

label 2026-06-01 13:26:22 +02:00

OragonEfreet added 1 commit 2026-06-01 13:51:37 +02:00

Wayland: bind only the libdecor symbols the backend uses (cert-dcl37-c) ... 4519fb59b4

The QA clang-tidy run (--checks=cert-*) flagged four _bj_libdecor_*
declarations as reserved identifiers (cert-dcl37-c): get_fd, dispatch,
frame_set_capabilities, and configuration_get_window_state. They were
resolved but never called; the used _bj_* shim symbols (here and in the
libwayland / libxkbcommon shims) do not trip the check. Drop the four
unused entry points from the shim, storage, resolver, and the README
table so the libdecor shim is all-used like the others.

No behaviour change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

OragonEfreet merged commit d8dadd66f5 into main 2026-06-01 13:54:51 +02:00

OragonEfreet deleted branch wayland-libdecor 2026-06-01 13:54:51 +02:00

OragonEfreet referenced this pull request from a commit 2026-06-01 13:54:52 +02:00

Resize fixes (#129) + Decoration on Wayland+GNOME

OragonEfreet referenced this pull request from a commit 2026-06-01 14:01:11 +02:00

Resize fixes (#129) + Decoration on Wayland+GNOME

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

1.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

OragonEfreet

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

OragonEfreet/banjo!129

No description provided.