OragonEfreet/banjo
OragonEfreet/banjo
1
0
Fork 0
Code Issues 16 Pull requests Projects 1 Releases 4 Activity Actions

Improve App callback mechanism #122

Merged
OragonEfreet merged 1 commit from release/1.0-update into release/1.0 2026-05-31 23:09:42 +02:00
Conversation 0 Commits 1 Files changed 26 +372 -803
OragonEfreet commented 2026-05-31 23:06:33 +02:00
Owner
Copy link
  1. Setup callback signature changed:
    • Before: void (bj_app_setup_fn)(struct bj_app app, void** user_data)
    • After: void* (bj_app_setup_fn)(struct bj_app app, void* init_data)

Setup now returns void* (the user_data for other callbacks) instead of using an output parameter.
2. bj_run_app signature changed:
- Before: bj_run_app(setup, step, fixed_step, teardown)
- After: bj_run_app(setup, step, fixed_step, teardown, init_data)

Added init_data parameter at the end to pass configuration from main() to setup

Reviewed-on: #121

1. Setup callback signature changed: - Before: void (*bj_app_setup_fn)(struct bj_app* app, void** user_data) - After: void* (*bj_app_setup_fn)(struct bj_app* app, void* init_data) Setup now returns void* (the user_data for other callbacks) instead of using an output parameter. 2. bj_run_app signature changed: - Before: bj_run_app(setup, step, fixed_step, teardown) - After: bj_run_app(setup, step, fixed_step, teardown, init_data) Added init_data parameter at the end to pass configuration from main() to setup Reviewed-on: https://forge.codework-orange.com/OragonEfreet/banjo/pulls/121
Improve App callback mechanism
All checks were successful
Documentation / build-docs (push) Successful in 8s
Details
QA / cert (push) Successful in 29s
Details
Build and Test / linux-linux-gcc (push) Successful in 17s
Details
Build and Test / linux-windows-mingw (push) Successful in 25s
Details
Documentation / build-docs (pull_request) Successful in 8s
Details
QA / cert (pull_request) Successful in 29s
Details
Build and Test / linux-linux-gcc (pull_request) Successful in 17s
Details
Build and Test / linux-windows-mingw (pull_request) Successful in 26s
Details
c286d6ed2f 
1. Setup callback signature changed:
    - Before: void (*bj_app_setup_fn)(struct bj_app* app, void** user_data)
    - After: void* (*bj_app_setup_fn)(struct bj_app* app, void* init_data)

  Setup now returns void* (the user_data for other callbacks) instead of using an output parameter.
  2. bj_run_app signature changed:
    - Before: bj_run_app(setup, step, fixed_step, teardown)
    - After: bj_run_app(setup, step, fixed_step, teardown, init_data)

  Added init_data parameter at the end to pass configuration from main() to setup

Reviewed-on: #121
OragonEfreet added this to the 1.0 milestone 2026-05-31 23:06:38 +02:00
OragonEfreet merged commit 4069592b40 into release/1.0 2026-05-31 23:09:42 +02:00
OragonEfreet deleted branch release/1.0-update 2026-05-31 23:09:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
1.0
Projects
Clear projects
No items
No project
70's games readinesss
Assignees
Clear assignees
No assignees
OragonEfreet
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
OragonEfreet/banjo!122
No description provided.