OragonEfreet/banjo
OragonEfreet/banjo
1
0
Fork 0
Code Issues 16 Pull requests Projects 1 Releases 4 Activity Actions

fix(x11): validate keycode range before keymap allocation #147

Merged
OragonEfreet merged 1 commit from fix/x11-keymap-validation into main 2026-06-03 20:00:26 +02:00
Conversation 0 Commits 1 Files changed 1 +12 -2
OragonEfreet commented 2026-06-03 17:56:49 +02:00
Owner
Copy link

Add validation for min_keycode and max_keycode values from
XDisplayKeycodes before using them in size calculations. Also
add null check for XGetKeyboardMapping result.

Prevents potential issues if X11 returns unexpected negative
values or if keyboard mapping query fails.

Add validation for min_keycode and max_keycode values from XDisplayKeycodes before using them in size calculations. Also add null check for XGetKeyboardMapping result. Prevents potential issues if X11 returns unexpected negative values or if keyboard mapping query fails.
fix(x11): validate keycode range before keymap allocation
All checks were successful
Documentation / build-docs (pull_request) Successful in 9s
Details
QA / cert (pull_request) Successful in 29s
Details
Build and Test / linux-linux-gcc / shared (pull_request) Successful in 16s
Details
Build and Test / linux-linux-gcc / static (pull_request) Successful in 17s
Details
Build and Test / linux-windows-mingw / shared (pull_request) Successful in 25s
Details
Build and Test / linux-windows-mingw / static (pull_request) Successful in 26s
Details
a91693bc81 
Add validation for min_keycode and max_keycode values from
XDisplayKeycodes before using them in size calculations. Also
add null check for XGetKeyboardMapping result.

Prevents potential issues if X11 returns unexpected negative
values or if keyboard mapping query fails.
OragonEfreet added this to the 1.0 milestone 2026-06-03 17:57:12 +02:00
OragonEfreet removed this from the 1.0 milestone 2026-06-03 20:00:22 +02:00
OragonEfreet deleted branch fix/x11-keymap-validation 2026-06-03 20:00:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
OragonEfreet
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
OragonEfreet/banjo!147
No description provided.