Various fixes #151

Merged

OragonEfreet merged 5 commits from oragonefreet-patch-1 into release/1.0 2026-06-03 20:45:48 +02:00

Conversation 0 Commits 5 Files changed 6 +108 -3

OragonEfreet commented 2026-06-03 20:42:42 +02:00

Owner

Copy link

Various fixes

Various fixes

OragonEfreet added 1 commit 2026-06-03 20:42:42 +02:00

fix(bitmap): handle INT32_MIN safely in LOCAL_ABS macro (#143) ... 1ae3a2aafe

Fix undefined behavior when negating INT32_MIN by using unsigned
arithmetic instead. The old macro `(uint32_t)(-(x))` would invoke
UB when x is INT32_MIN because -INT32_MIN overflows int32_t.

The new approach casts to uint32_t first, then uses unsigned
subtraction: `(uint32_t)0 - (uint32_t)(x)`, which is well-defined.

Reviewed-on: #143

OragonEfreet added 1 commit 2026-06-03 20:42:52 +02:00

fix(physics): guard against division by zero in point gravity (#144) ... 507a4336a5

Add checks for zero inverse_mass (infinite mass) before computing
gravitational force. Particles with infinite mass should not have
gravity forces applied to them, and division by zero inverse_mass
would cause undefined behavior.

Affects:
- bj_apply_point_gravity_2d
- bj_apply_point_gravity_softened_2d

Reviewed-on: #144

OragonEfreet added 1 commit 2026-06-03 20:42:59 +02:00

fix(bitmap): add overflow check for buffer size calculation (#148) ... 47757398ea

Add overflow check before computing stride * height to prevent
integer overflow when allocating bitmap buffer. On systems where
size_t is 32-bit, large dimensions could overflow and cause
undersized buffer allocation.

Reviewed-on: #148

OragonEfreet added 1 commit 2026-06-03 20:43:06 +02:00

fix(audio): check pthread_create return in ALSA backend (#149) ... 2e7c5bd268

Add error checking for pthread_create() in alsa_open_device().
Previously, if thread creation failed, the device would be returned
as if successfully initialized, leading to a broken audio device.

Also adds null check for audio buffer allocation.

Reviewed-on: #149

OragonEfreet added 1 commit 2026-06-03 20:43:12 +02:00

fix(net): add null checks after allocation in network code (#150) ... 74de3b4bb1

Add null checks after all bj_calloc() calls in both POSIX and Win32
network implementations. Previously, allocation failures would cause
null pointer dereferences. Now properly sets error and returns NULL,
with appropriate resource cleanup (closing sockets, freeing addrinfo).

Affected functions:
- bj_resolve_address
- bj_listen_tcp
- bj_connect_tcp
- bj_connect_tcp_to
- bj_accept_tcp
- bj_open_udp
- bj_udp_recv

Reviewed-on: #150

OragonEfreet changed title from fix(bitmap): handle INT32_MIN safely in LOCAL_ABS macro (#143) to Various fixes 2026-06-03 20:43:51 +02:00

OragonEfreet merged commit 74de3b4bb1 into release/1.0 2026-06-03 20:45:48 +02:00

OragonEfreet deleted branch oragonefreet-patch-1 2026-06-03 20:45:48 +02:00

OragonEfreet added this to the 1.0 milestone 2026-06-04 19:46:08 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

1.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

OragonEfreet/banjo!151

No description provided.